[
https://issues.apache.org/jira/browse/PHOENIX-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020325#comment-16020325
]
Hadoop QA commented on PHOENIX-3248:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12869340/PHOENIX-3248.002.patch
against master branch at commit e27fae93191d9540574765065900a23bda90905f.
ATTACHMENT ID: 12869340
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:red}-1 release audit{color}. The applied patch generated 3 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ ScanMetricsHolder scanMetricsHolder =
ScanMetricsHolder.getInstance(readMetrics, tableName, scan,
+ final ScanMetricsHolder scanMetricsHolder =
ScanMetricsHolder.getInstance(readMetrics, physicalTableName,
+ public ScanningResultIterator(ResultScanner scanner, Scan scan,
ScanMetricsHolder scanMetricsHolder) {
+
scanMetricsHolder.getCountOfRPCcalls().change(scanMetricsMap.get(RPC_CALLS_METRIC_NAME));
+
scanMetricsHolder.getCountOfRemoteRPCcalls().change(scanMetricsMap.get(REMOTE_RPC_CALLS_METRIC_NAME));
+
scanMetricsHolder.getSumOfMillisSecBetweenNexts().change(scanMetricsMap.get(MILLIS_BETWEEN_NEXTS_METRIC_NAME));
+
scanMetricsHolder.getCountOfNSRE().change(scanMetricsMap.get(NOT_SERVING_REGION_EXCEPTION_METRIC_NAME));
+
scanMetricsHolder.getCountOfBytesInResults().change(scanMetricsMap.get(BYTES_IN_RESULTS_METRIC_NAME));
+
scanMetricsHolder.getCountOfBytesInRemoteResults().change(scanMetricsMap.get(BYTES_IN_REMOTE_RESULTS_METRIC_NAME));
+
scanMetricsHolder.getCountOfRegions().change(scanMetricsMap.get(REGIONS_SCANNED_METRIC_NAME));
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/886//testReport/
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/886//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/886//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/886//console
This message is automatically generated.
> Enable HBase server-side scan metrics to be returned to client and surfaced
> through metrics
> -------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3248
> URL: https://issues.apache.org/jira/browse/PHOENIX-3248
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Karan Mehta
> Attachments: PHOENIX-3248.002.patch, PHOENIX-3248.patch
>
>
> We collect many client-side metrics[1] for Phoenix statements. We should
> enable returning the more detailed server-side HBase scan metrics (through
> Scan.setScanMetricsEnabled(true) and Scan.getScanMetrics()), and then
> incorporate these into our client-side metrics.
> [1] https://phoenix.apache.org/metrics.html
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
