[ https://issues.apache.org/jira/browse/PHOENIX-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078620#comment-16078620 ]
Josh Elser commented on PHOENIX-4004: ------------------------------------- Forgot to add, the total "benefit" I was able to observe from this change (including things that are already fixed in Apache) on a wimpy 5-node cluster with YCSB was a 5-10% increase in throughput for an 80/20 write/read workload with two secondary indices. > Assorted improvements to reduce garbage in mutable index codepath > ----------------------------------------------------------------- > > Key: PHOENIX-4004 > URL: https://issues.apache.org/jira/browse/PHOENIX-4004 > Project: Phoenix > Issue Type: Improvement > Reporter: Josh Elser > Assignee: Josh Elser > Priority: Minor > Fix For: 4.12.0 > > > During some $dayjob testing, I found a couple of places where we were > unnecessarily creating garbage in the RS. When "forward-porting" this change, > most of the areas were already cleaned up but there are a few that still > apply. > * ArrayList initial sizing > * Avoid indirection of the (single-threaded) ExecutorService in > IndexBuildManager (just pure overhead) > * Some unnecessary KeyValue copies and an array copy (an avoidance of > deprecated HBase API) > * Avoid extra {{System.arraycopy}} calls in CoveredColumnIndexCodec via the > {{ArrayUtils.addAll}} call -- This message was sent by Atlassian JIRA (v6.4.14#64029)