[
https://issues.apache.org/jira/browse/PHOENIX-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078857#comment-16078857
]
Hadoop QA commented on PHOENIX-4004:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12876134/PHOENIX-4004.001.patch
against master branch at commit 0f45a541bc23a7e7064f8ecb9ef4925bce64b570.
ATTACHMENT ID: 12876134
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
47 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ // Avoid multiple internal array resizings. Initial size of 64, unless
we have fewer cells in the edit
+ Collection<Pair<Mutation, byte[]>> indexUpdates = new
ArrayList<Pair<Mutation, byte[]>>(initialSize);
+ this.addUpdateCells(this.table.getCurrentRowState(update, toCover,
ignoreNewerMutations).listCells(), false);
+ // output = length of values + primary key + column entries + length
of each column entry + number of column entries
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexFailureIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1181//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1181//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1181//console
This message is automatically generated.
> Assorted improvements to reduce garbage in mutable index codepath
> -----------------------------------------------------------------
>
> Key: PHOENIX-4004
> URL: https://issues.apache.org/jira/browse/PHOENIX-4004
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Minor
> Fix For: 4.12.0
>
> Attachments: PHOENIX-4004.001.patch
>
>
> During some $dayjob testing, I found a couple of places where we were
> unnecessarily creating garbage in the RS. When "forward-porting" this change,
> most of the areas were already cleaned up but there are a few that still
> apply.
> * ArrayList initial sizing
> * Avoid indirection of the (single-threaded) ExecutorService in
> IndexBuildManager (just pure overhead)
> * Some unnecessary KeyValue copies and an array copy (an avoidance of
> deprecated HBase API)
> * Avoid extra {{System.arraycopy}} calls in CoveredColumnIndexCodec via the
> {{ArrayUtils.addAll}} call
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
