[ 
https://issues.apache.org/jira/browse/PHOENIX-4004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096894#comment-16096894
 ] 

Josh Elser commented on PHOENIX-4004:
-------------------------------------

Thanks, Andrew!

Pushing this one before I forget about it again.

> Assorted improvements to reduce garbage in mutable index codepath
> -----------------------------------------------------------------
>
>                 Key: PHOENIX-4004
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4004
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Minor
>             Fix For: 4.12.0
>
>         Attachments: PHOENIX-4004.001.patch, PHOENIX-4004.002.patch
>
>
> During some $dayjob testing, I found a couple of places where we were 
> unnecessarily creating garbage in the RS. When "forward-porting" this change, 
> most of the areas were already cleaned up but there are a few that still 
> apply.
> * ArrayList initial sizing
> * Avoid indirection of the (single-threaded) ExecutorService in 
> IndexBuildManager (just pure overhead)
> * Some unnecessary KeyValue copies and an array copy (an avoidance of 
> deprecated HBase API)
> * Avoid extra {{System.arraycopy}} calls in CoveredColumnIndexCodec via the 
> {{ArrayUtils.addAll}} call



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to