[ 
https://issues.apache.org/jira/browse/PHOENIX-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16080627#comment-16080627
 ] 

Thomas D'Silva commented on PHOENIX-3978:
-----------------------------------------

[~samarthjain]

Can you please review?

> Expose mutation failures in our metrics
> ---------------------------------------
>
>                 Key: PHOENIX-3978
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3978
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Samarth Jain
>            Assignee: Thomas D'Silva
>         Attachments: PHOENIX-3978.patch
>
>
> We should be exposing whether a mutation has failed through our metrics 
> system. This should be done both within global and request level metrics. 
> The task basically boils down to:
> 1) Adding a new enum MUTATION_BATCH_FAILED_COUNTER in MetricType.
> 2) Adding a new enum GLOBAL_MUTATION_BATCH_FAILED_COUNTER in 
> GlobalClientMetrics
> 3) Adding a new CombinableMetric member called mutationBatchFailed to 
> MutationMetric class
> 4) Making sure that the two metrics are updated within the catch exception 
> block of MutationState#send()
> 5) Unit test in PhoenixMetricsIT
> FYI, [~tdsilva]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to