[
https://issues.apache.org/jira/browse/PHOENIX-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084267#comment-16084267
]
Samarth Jain commented on PHOENIX-3978:
---------------------------------------
Thanks for the updated patch, [~tdsilva]. Looks good. One comment:
I am not sure if this test is doing the right thing.
{code}
@Test
+ public void testUniqueShortNames() throws Exception {
+ Map<String, MetricType> shortNameMap =
Maps.newHashMapWithExpectedSize(MetricType.values().length);
+ for (MetricType type : MetricType.values()) {
+ if (shortNameMap.containsKey(type.shortName())) {
+ fail("Metric short names should be unique found
duplicates for " + type.name() + " and "
+ +
shortNameMap.get(type.shortName()).name());
+ }
+ }
+ }
{code}
The if part should read like this?
{code}
if (shortNameMap.put(type.shortName(), type) != null) {
....
{code}
> Expose mutation failures in our metrics
> ---------------------------------------
>
> Key: PHOENIX-3978
> URL: https://issues.apache.org/jira/browse/PHOENIX-3978
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Thomas D'Silva
> Attachments: PHOENIX-3978-4.x-HBase-0.98-v2.patch,
> PHOENIX-3978.patch, PHOENIX-3978-v2.patch
>
>
> We should be exposing whether a mutation has failed through our metrics
> system. This should be done both within global and request level metrics.
> The task basically boils down to:
> 1) Adding a new enum MUTATION_BATCH_FAILED_COUNTER in MetricType.
> 2) Adding a new enum GLOBAL_MUTATION_BATCH_FAILED_COUNTER in
> GlobalClientMetrics
> 3) Adding a new CombinableMetric member called mutationBatchFailed to
> MutationMetric class
> 4) Making sure that the two metrics are updated within the catch exception
> block of MutationState#send()
> 5) Unit test in PhoenixMetricsIT
> FYI, [~tdsilva]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
