[
https://issues.apache.org/jira/browse/PHOENIX-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083373#comment-16083373
]
Hadoop QA commented on PHOENIX-3978:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12876720/PHOENIX-3978-v2.patch
against master branch at commit b7b571b7db0c58ff488e435d5a3cf6c45a41fe86.
ATTACHMENT ID: 12876720
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
50 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ Map<String, Map<MetricType, Long>> mutationWriteMetrics =
PhoenixRuntime.getWriteMetricInfoForMutationsSinceLastReset(con);
+ assertEquals(expectedUncommittedStatementIndexes.length,
mutationWriteMetrics.get(B_FAILURE_TABLE).get(MUTATION_BATCH_FAILED_SIZE).intValue());
+ assertEquals(expectedUncommittedStatementIndexes.length,
GLOBAL_MUTATION_BATCH_FAILED_COUNT.getMetric().getTotalSum());
+ Map<String, Map<MetricType, Long>> mutationMetrics =
PhoenixRuntime.getWriteMetricInfoForMutationsSinceLastReset(pConn);
+ Map<String, Map<MetricType, Long>> readMetrics =
PhoenixRuntime.getReadMetricInfoForMutationsSinceLastReset(pConn);
+ Map<String, Map<MetricType, Long>> mutationMetrics =
PhoenixRuntime.getWriteMetricInfoForMutationsSinceLastReset(pConn);
+ Map<String, Map<MetricType, Long>> readMetrics =
PhoenixRuntime.getReadMetricInfoForMutationsSinceLastReset(pConn);
+ Map<String, Map<MetricType, Long>> mutationMetrics =
PhoenixRuntime.getWriteMetricInfoForMutationsSinceLastReset(pConn);
+ Map<String, Map<MetricType, Long>> readMetrics =
PhoenixRuntime.getReadMetricInfoForMutationsSinceLastReset(pConn);
+ Map<String, Map<MetricType, Long>> readMetrics =
PhoenixRuntime.getRequestReadMetricInfo(rs);
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ImmutableIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ImmutableIndexWithStatsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.SaltedViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.hadoop.hbase.regionserver.wal.WALReplayWithIndexWritesAndCompressedWALIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.NotQueryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ClientTimeArithmeticQueryIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1197//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1197//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1197//console
This message is automatically generated.
> Expose mutation failures in our metrics
> ---------------------------------------
>
> Key: PHOENIX-3978
> URL: https://issues.apache.org/jira/browse/PHOENIX-3978
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Thomas D'Silva
> Attachments: PHOENIX-3978-4.x-HBase-0.98-v2.patch,
> PHOENIX-3978.patch, PHOENIX-3978-v2.patch
>
>
> We should be exposing whether a mutation has failed through our metrics
> system. This should be done both within global and request level metrics.
> The task basically boils down to:
> 1) Adding a new enum MUTATION_BATCH_FAILED_COUNTER in MetricType.
> 2) Adding a new enum GLOBAL_MUTATION_BATCH_FAILED_COUNTER in
> GlobalClientMetrics
> 3) Adding a new CombinableMetric member called mutationBatchFailed to
> MutationMetric class
> 4) Making sure that the two metrics are updated within the catch exception
> block of MutationState#send()
> 5) Unit test in PhoenixMetricsIT
> FYI, [~tdsilva]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
