Github user ChinmaySKulkarni commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/295#discussion_r176568690
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2405,16 +2413,26 @@ public Void call() throws Exception {
openConnection();
hConnectionEstablished = true;
boolean isDoNotUpgradePropSet =
UpgradeUtil.isNoUpgradeSet(props);
+ boolean doesSystemCatalogAlreadyExist = false;
--- End diff --
@JamesRTaylor thanks for the review. I've submitted a patch for
PHOENIX-4668 and will go ahead with the changes you've mentioned for this
patch. I'm not sure about the status of PHOENIX-4575 (@mujtabachohan was
working on this before his vacation), so don't want to make any changes to it
without understanding its scope.
Thanks.
---
