[GitHub] phoenix pull request #295: PHOENIX-4579: Add a config to conditionally creat...

[JamesRTaylor]

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/295#discussion_r176783002
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ---
    @@ -2405,16 +2413,26 @@ public Void call() throws Exception {
                                 openConnection();
                                 hConnectionEstablished = true;
                                 boolean isDoNotUpgradePropSet = 
UpgradeUtil.isNoUpgradeSet(props);
    +                            boolean doesSystemCatalogAlreadyExist = false;
    --- End diff --
    
    Good points. How about if we leave the ensureTableCreated call where it is, 
but move the logic in that try block of the init method into the 
ensureTableCreated method so it’s consolidated?


---