Github user ChinmaySKulkarni commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/295#discussion_r176617368
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
---
@@ -2405,16 +2413,26 @@ public Void call() throws Exception {
openConnection();
hConnectionEstablished = true;
boolean isDoNotUpgradePropSet =
UpgradeUtil.isNoUpgradeSet(props);
+ boolean doesSystemCatalogAlreadyExist = false;
--- End diff --
@JamesRTaylor @twdsilva also, do we really want to avoid calling
ensureTableCreated from createTable in case it is a system table? Apart from
actually ensuring that the table is created or not and the client-server
compatibility checks, this method also modifies the table according to a new
descriptor (I don't have enough background as to why we do this here). Any
advice guys?
---
