[
https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422752#comment-16422752
]
Andrew Purtell commented on PHOENIX-4682:
-----------------------------------------
Patch basically lgtm.
Definitely good if Phoenix can avoid throwing for all cases from this code, of
course, but to be a bit pedantic (sorry) preCompactScannerOpen is declared to
throw IOException, and this is acceptable when serious conditions require error
handling. That the error handling likely to be an RS abort is a matter for
higher layers.
Anyway, if you're amenable to changing the description and commit message for
this to something like "Ignore non Phoenix tables in
UngroupedAggregateRegionObserver#preCompactScannerOpen" then +1 from me.
> UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw
> exceptions
> ---------------------------------------------------------------------------------------
>
> Key: PHOENIX-4682
> URL: https://issues.apache.org/jira/browse/PHOENIX-4682
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.13.0
> Reporter: Vincent Poon
> Assignee: Vincent Poon
> Priority: Major
> Attachments: PHOENIX-4682.master.v1.patch
>
>
> TableNotFoundException in the preCompactScannerOpen hook can lead to RS abort.
> Some tables might have the phoenix coprocessor loaded but not be actual
> Phoenix tables (i.e. have a row in SYSTEM.CATALOG). We should ignore these
> Exceptions instead of throwing them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
