[ 
https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422919#comment-16422919
 ] 

Geoffrey Jacoby commented on PHOENIX-4682:
------------------------------------------

[~vincentpoon] - the issue's not whether your logic can handle System.Catalog 
because it's a Phoenix table. It's whether, if we're compacting System.Catalog, 
a call to PhoenixRuntime.getTableNoCache, which _queries System.Catalog_ will 
succeed or throw NotServingRegionException or some kind of timeout. If we know 
that it will, then we should just skip the logic. 

Even if it succeeds, is there a timeout on the compaction call that might 
interact with the syscat call?

Oh, and one other nitpick while I'm looking – if the request.isMajor call 
doesn't need to be done under a given user, can that be extracted from the 
User.runAsLoginUser() block so that minor compactions won't have to do the 
login parts?

> UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw 
> exceptions
> ---------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4682
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4682
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.13.0
>            Reporter: Vincent Poon
>            Assignee: Vincent Poon
>            Priority: Major
>         Attachments: PHOENIX-4682.master.v1.patch
>
>
> TableNotFoundException in the preCompactScannerOpen hook can lead to RS abort.
> Some tables might have the phoenix coprocessor loaded but not be actual 
> Phoenix tables (i.e. have a row in SYSTEM.CATALOG).  We should ignore these 
> Exceptions instead of throwing them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to