[
https://issues.apache.org/jira/browse/PHOENIX-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423096#comment-16423096
]
James Taylor commented on PHOENIX-4682:
---------------------------------------
Thanks, [~vincentpoon]. Patch looks good, but a couple of minor nits:
- Unless collecting stats for SYSTEM.CATALOG is causing a specific issue, I
don't think we should special case it not to do so. It's a Phoenix table like
any other Phoenix table so if it's configured to have stats gathered for it,
then it should IMHO.
- How about just catching TableNotFoundException here instead of having the
instance of check?
{code}
+ } catch (Exception e) {
+ if (e instanceof TableNotFoundException) {
+ logger.debug("Ignoring HBase table that is not
a Phoenix table: " + fullTableName);
+ // non-Phoenix HBase tables won't be found, do
nothing
+ } else {
+ logger.error("Unable to modify compaction
scanner to retain deleted cells for a table with disabled Index; "
+ + fullTableName,
+ e);
+ }
{code}
> UngroupedAggregateRegionObserver preCompactScannerOpen hook should not throw
> exceptions
> ---------------------------------------------------------------------------------------
>
> Key: PHOENIX-4682
> URL: https://issues.apache.org/jira/browse/PHOENIX-4682
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.13.0
> Reporter: Vincent Poon
> Assignee: Vincent Poon
> Priority: Major
> Attachments: PHOENIX-4682.master.v1.patch, PHOENIX-4682.v2.0.98.patch
>
>
> TableNotFoundException in the preCompactScannerOpen hook can lead to RS abort.
> Some tables might have the phoenix coprocessor loaded but not be actual
> Phoenix tables (i.e. have a row in SYSTEM.CATALOG). We should ignore these
> Exceptions instead of throwing them.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
