+1 (binding) rat-check: OK Build with master + patch: OK verified signature and checksum: OK
Thanks for the help, Istvan! Geoffrey On Thu, Apr 14, 2022 at 12:47 PM Istvan Toth <[email protected]> wrote: > Yes, Geoffrey, you need this patch for Phoenix: > (it's old, possibly needs updating) > https://github.com/apache/phoenix/pull/1344 > > That's why we've bumped the version to 2.0 > > Istvan > > On Thu, Apr 14, 2022 at 6:43 PM Geoffrey Jacoby <[email protected]> > wrote: > > > -1 (I'm happy to change my vote if I made a mistake somewhere ) > > > > mvn clean apache-rat:check: OK > > mvn clean install on phoenix-thirdparty: OK > > mvn clean package from phoenix master branch with > > phoenix.thirdparty.version changed to 2.0.0: FAILED > > > > I have about 10 build errors that all look similar to the following: > > > > PhoenixRuntime.java:[721,40] DefaultParser(boolean,java.lang.Boolean) has > > private access in > > org.apache.phoenix.thirdparty.org.apache.commons.cli.DefaultParser > > > > > > I tried this on both a work laptop and a personal machine (the latter > had a > > fresh clone of phoenix and phoenix-thirdparty) with the same result. > > > > > > I'm guessing this is related to going from our patched commons-cli back > to > > shading an official one? > > > > > > Geoffrey > > > > On Thu, Apr 14, 2022 at 10:01 AM Viraj Jasani <[email protected]> > wrote: > > > > > +1 > > > > > > * Signature/Checksum: ok > > > * Rat check: ok > > > * Build Phoenix master against RC: ok > > > > > > > > > On Mon, 11 Apr 2022 at 1:05 PM, Istvan Toth <[email protected]> wrote: > > > > > > > Please vote on this Apache Phoenix Thirdparty release candidate, > > > > phoenix-thirdparty-2.0.0RC1 > > > > > > > > The VOTE will remain open for at least 72 hours. > > > > > > > > [ ] +1 Release this package as Apache phoenix thirdparty 2.0.0 > > > > [ ] -1 Do not release this package because ... > > > > > > > > The tag to be voted on is 2.0.0RC0: > > > > > > > > https://github.com/apache/phoenix-thirdparty/tree/2.0.0RC1 > > > > > > > > The release files, including signatures, digests, as well as > CHANGES.md > > > > and RELEASENOTES.md included in this RC can be found at: > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/phoenix/phoenix-thirdparty-2.0.0RC1/ > > > > > > > > Maven artifacts are available in the "orgapachephoenix-1244" staging > > > > repository at: > > > > > > > > https://repository.apache.org/#stagingRepositories > > > > > > > > Artifacts were signed with the 0x794433C7 key which can be found in: > > > > > > > > https://dist.apache.org/repos/dist/release/phoenix/KEYS > > > > > > > > To learn more about Apache Phoenix Thirdparty, please see > > > > > > > > https://phoenix.apache.org/ > > > > > > > > Thanks, > > > > Istvan > > > > > > > > > > > > -- > *István Tóth* | Staff Software Engineer > [email protected] <https://www.cloudera.com> > [image: Cloudera] <https://www.cloudera.com/> > [image: Cloudera on Twitter] <https://twitter.com/cloudera> [image: > Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera > on LinkedIn] <https://www.linkedin.com/company/cloudera> > <https://www.cloudera.com/> > ------------------------------ >
