Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10005589
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/schema/PArrayDataType.java ---
@@ -39,36 +49,64 @@ public PArrayDataType() {
if(object == null) {
throw new ConstraintViolationException(this + " may not
be null");
}
- int size = PDataType.fromTypeId((baseType.getSqlType() +
Types.ARRAY)).estimateByteSize(object);
-
+ Pair<Integer, Integer> nullsVsNullRepeationCounter = new
Pair<Integer, Integer>();
+ int size = estimateByteSize(object, nullsVsNullRepeationCounter,
+ PDataType.fromTypeId((baseType.getSqlType() +
Types.ARRAY)));
int noOfElements = ((PhoenixArray)object).numElements;
if(noOfElements == 0) {
return ByteUtil.EMPTY_BYTE_ARRAY;
}
- ByteBuffer buffer;
- int capacity = 0;
+
+ TrustedByteArrayOutputStream byteStream = null;
if (!baseType.isFixedWidth() ||
baseType.isCoercibleTo(PDataType.VARCHAR)) {
- // variable
- if (calculateMaxOffset(size)) {
- // Use Short to represent the offset
- capacity = initOffsetArray(noOfElements,
Bytes.SIZEOF_SHORT);
- } else {
- capacity = initOffsetArray(noOfElements,
Bytes.SIZEOF_INT);
- // Negate the number of elements
- noOfElements = -noOfElements;
- }
- buffer = ByteBuffer.allocate(size + capacity +
Bytes.SIZEOF_INT+ Bytes.SIZEOF_BYTE);
+ // Any variable length array would follow the below order
--- End diff --
Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
