Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/incubator-phoenix/pull/8#discussion_r10139260
  
    --- Diff: 
phoenix-core/src/test/java/org/apache/phoenix/end2end/ArrayTest.java ---
    @@ -393,6 +393,73 @@ public void testSelectWithArrayWithColumnRef() throws 
Exception {
         }
         
    --- End diff --
    
    Consider a case where there are 3 nulls in  middle and rest of the elements 
are same.  And another array with 5 nulls in the middle.  Now the one with 3 
nulls is the lowest.  
    But my point is in the case where the nullCount % 256 (say nullcount is 
234) now the nullbytecount is 22.  And another array with exactly 22 middle 
elements .  How do we differentiate which one is bigger? Here the comparison 
will make the one with 234 nulls as small based on the offset arrays byte 
comparsion because the val part is going to be the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to