Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/incubator-phoenix/pull/8#discussion_r10133071
--- Diff:
phoenix-core/src/test/java/org/apache/phoenix/end2end/ArrayTest.java ---
@@ -393,6 +393,73 @@ public void testSelectWithArrayWithColumnRef() throws
Exception {
}
--- End diff --
You make a good point.The one with fewer nulls is going to sort before the
one with more nulls, which isn't what we want. Does this test succeed?
We need to invert the byte that counts the nulls: you can use byte
nullCountByte = SortOrder.invert(nullCountByte); Then it'll sort correctly.
Sorry, I missed that before
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
