Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/incubator-phoenix/pull/8#discussion_r10115369
  
    --- Diff: 
phoenix-core/src/test/java/org/apache/phoenix/end2end/ArrayTest.java ---
    @@ -393,6 +393,73 @@ public void testSelectWithArrayWithColumnRef() throws 
Exception {
         }
         
    --- End diff --
    
    Have another test that demonstrates the need for separator bytes:
    
        String strArr1[] = new String[] {"a","c"};
        String strArr2[] = new String[] {"ab"};
        // create arrays for strArr1 and strArr2 and then serialize them to 
bytes1 and bytes2
        ...
        // Compare arrays strArr1 is smaller than strArr2, since "a" is less 
than "ab"
        // Demonstrates the need for putting separator bytes after each 
element, 
        // as otherwise, if element values were just concatenated, this would 
fail.
        assertTrue(Bytes.compareTo(bytes1, bytes2) < 0);
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to