> On Aug. 14, 2013, 7:35 p.m., Cheolsoo Park wrote: > > Can you run the unit tests when you commit it? Thanks!
Have run the full suite of unit tests and e2e tests as it makes change to basic parsing. They pass - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13535/#review25173 ----------------------------------------------------------- On Aug. 13, 2013, 2:34 p.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13535/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 2:34 p.m.) > > > Review request for pig. > > > Bugs: PIG-3204 > https://issues.apache.org/jira/browse/PIG-3204 > > > Repository: pig > > > Description > ------- > > Change parsing from line by line to whole script at once. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/PigServer.java > 1510960 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/tools/grunt/GruntParser.java > 1510960 > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestGrunt.java > 1510960 > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPigServer.java > 1510960 > > Diff: https://reviews.apache.org/r/13535/diff/ > > > Testing > ------- > > New unit tests added to track the number of times a line is parsed. TestGrunt > and TestShortcuts test failures fixed. > > > Thanks, > > Rohini Palaniswamy > >
