> On Aug. 14, 2013, 2:13 a.m., Cheolsoo Park wrote: > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPigServer.java, > > line 776 > > <https://reviews.apache.org/r/13535/diff/2/?file=340614#file340614line776> > > > > This is a bit confusing to me. 10 - 4 + 6 = 12, but numTimesInitiated > > is set to 10. > > > > _testSkipParseInRegisterForBatch(false, 10, 4); > > Rohini Palaniswamy wrote: > It is 10 (4 + 6). Will change the hyphen to full stop so that it is not > mistaken as minus. > > Cheolsoo Park wrote: > I see. Thanks! > > Btw, why are there 7 function calls instead of 6? Is this a typo? > > 6 (parseAndBuild, launchPlan->RandomSampleLoader, > InputSizeReducerEstimator, getSplits->RandomSampleLoader, > createRecordReader->RandomSampleLoader, getSplits, createRecordReader)
I guess it is. Did this long ago that I have forgotten. Will step through and remove the one from comment that is not applicable. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13535/#review25098 ----------------------------------------------------------- On Aug. 13, 2013, 2:34 p.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13535/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 2:34 p.m.) > > > Review request for pig. > > > Bugs: PIG-3204 > https://issues.apache.org/jira/browse/PIG-3204 > > > Repository: pig > > > Description > ------- > > Change parsing from line by line to whole script at once. > > > Diffs > ----- > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/PigServer.java > 1510960 > > http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/tools/grunt/GruntParser.java > 1510960 > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestGrunt.java > 1510960 > > http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestPigServer.java > 1510960 > > Diff: https://reviews.apache.org/r/13535/diff/ > > > Testing > ------- > > New unit tests added to track the number of times a line is parsed. TestGrunt > and TestShortcuts test failures fixed. > > > Thanks, > > Rohini Palaniswamy > >
