sunithabeeram commented on a change in pull request #3568: Add guava cache to
cache table schema in pinot broker
URL: https://github.com/apache/incubator-pinot/pull/3568#discussion_r237748047
##########
File path:
pinot-broker/src/main/java/com/linkedin/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -78,13 +93,16 @@
public BaseBrokerRequestHandler(Configuration config, RoutingTable
routingTable,
TimeBoundaryService timeBoundaryService, AccessControlFactory
accessControlFactory,
- TableQueryQuotaManager tableQueryQuotaManager, BrokerMetrics
brokerMetrics) {
+ TableQueryQuotaManager tableQueryQuotaManager,
ZkHelixPropertyStore<ZNRecord> propertyStore,
+ BrokerMetrics brokerMetrics) {
_config = config;
_routingTable = routingTable;
_timeBoundaryService = timeBoundaryService;
_accessControlFactory = accessControlFactory;
_tableQueryQuotaManager = tableQueryQuotaManager;
+ _propertyStore = propertyStore;
_brokerMetrics = brokerMetrics;
+ _tableSchemaCache = new TableSchemaCache(_propertyStore);
Review comment:
It might be worth it to keep the tableSchemaCache as a top level citizen
that gets passed in (instead of property-store). Its possible classes outside
of the RequestHandler might need access to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
