sunithabeeram commented on a change in pull request #3568: Add guava cache to
cache table schema in pinot broker
URL: https://github.com/apache/incubator-pinot/pull/3568#discussion_r255360894
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -207,13 +213,15 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable RequesterIdentit
}
// Set extra settings into broker request
- if (request.has(TRACE) && request.get(TRACE).asBoolean()) {
+ if (requestParams.isTrace()) {
LOGGER.debug("Enable trace for request {}: {}", requestId, query);
brokerRequest.setEnableTrace(true);
}
- if (request.has(DEBUG_OPTIONS)) {
- Map<String, String> debugOptions =
Splitter.on(';').omitEmptyStrings().trimResults().withKeyValueSeparator('=')
- .split(request.get(DEBUG_OPTIONS).asText());
+ Map<String, String> debugOptions = requestParams.getDebugOptions();
+ if (debugOptions != null) {
+// if (request.has(DEBUG_OPTIONS)) {
Review comment:
Please remove commented out code if its not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
