sunithabeeram commented on a change in pull request #3568: Add guava cache to
cache table schema in pinot broker
URL: https://github.com/apache/incubator-pinot/pull/3568#discussion_r255361798
##########
File path:
pinot-common/src/main/java/com/linkedin/pinot/common/utils/CommonConstants.java
##########
@@ -118,10 +118,15 @@ public ServerType getServerType() {
public static final String
CONFIG_OF_BROKER_REFRESH_TIMEBOUNDARY_INFO_SLEEP_INTERVAL =
"pinot.broker.refresh.timeBoundaryInfo.sleepInterval";
public static final long
DEFAULT_BROKER_REFRESH_TIMEBOUNDARY_INFO_SLEEP_INTERVAL_MS = 10000L;
+ public static final String CONFIG_OF_TABLE_SCHEMA_MAXIMUM_CACHE_SIZE =
"pinot.broker.table.schema.cache.size";
Review comment:
@kishoreg I don't believe that is correct. We want to maintain a LRU cache -
so if we have a lot of tables, the frequently queried ones will stay in memory
and we'll hit ZK only for the ones not in memory. We should limit the in memory
size to guard against pathological cases where the size grows unbounded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
