mayankshriv commented on a change in pull request #3511: [PINOT-7370] Track
bytes read per query
URL: https://github.com/apache/incubator-pinot/pull/3511#discussion_r243366201
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/common/DataFetcher.java
##########
@@ -183,6 +194,10 @@ public void fetchStringValues(String column, int[]
inDocIds, int length, String[
} else {
_singleValueSetMap.get(column).getStringValues(inDocIds, 0, length,
outValues, 0);
}
+ // todo: optimize!
+ for( String val : outValues) {
Review comment:
This can be really expensive for low latency/high throughput use cases. You
can optimize it by computing the length inside of
SingleValueSet.getStringValues, since it is looping over the strings anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
