mayankshriv commented on a change in pull request #3511: [PINOT-7370] Track
bytes read per query
URL: https://github.com/apache/incubator-pinot/pull/3511#discussion_r243369549
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/operator/docidsets/BitmapDocIdSet.java
##########
@@ -23,19 +23,28 @@
public class BitmapDocIdSet implements FilterBlockDocIdSet {
private final ImmutableRoaringBitmap _bitmap;
+ private final long _bitMapCount;
+ private final long _totalBitMapBytesRead;
private int _startDocId;
// Inclusive
private int _endDocId;
public BitmapDocIdSet(ImmutableRoaringBitmap[] bitmaps, int startDocId, int
endDocId, boolean exclusive) {
- int numBitmaps = bitmaps.length;
- if (numBitmaps > 1) {
+ _bitMapCount = bitmaps.length;
+
+ if (_bitMapCount > 1) {
+ // estimate the number of bytes read
+ long bytesRead = 0;
+ for(ImmutableRoaringBitmap bitMap : bitmaps) {
Review comment:
Can we optimize this linear algorithm?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
