mayankshriv commented on a change in pull request #3511: [PINOT-7370] Track
bytes read per query
URL: https://github.com/apache/incubator-pinot/pull/3511#discussion_r243370360
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/operator/docidsets/ScanBasedSingleValueDocIdSet.java
##########
@@ -72,6 +74,16 @@ public long getNumEntriesScannedInFilter() {
return blockValSetBlockDocIdIterator.getNumEntriesScanned();
}
+ @Override
+ public long getNumIndicesLoaded() {
+ return 0L;
+ }
+
+ @Override
+ public long getTotalBytesRead() {
+ return getNumEntriesScannedInFilter() * dataTypeSizeInBytes;
Review comment:
A better approximation of length for variable length data types would be avg
length (right now it seems to use max length). This can be precomputed during
segment generation and stored in the metadata.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
