mcvsubbu commented on a change in pull request #3644: Split ValidationManager
duties into separate ControllerPeriodicTasks
URL: https://github.com/apache/incubator-pinot/pull/3644#discussion_r245750054
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerConf.java
##########
@@ -51,15 +51,40 @@
private static final String CONSOLE_WEBAPP_ROOT_PATH =
"controller.query.console";
private static final String CONSOLE_WEBAPP_USE_HTTPS =
"controller.query.console.useHttps";
private static final String EXTERNAL_VIEW_ONLINE_TO_OFFLINE_TIMEOUT =
"controller.upload.onlineToOfflineTimeout";
- private static final String RETENTION_MANAGER_FREQUENCY_IN_SECONDS =
"controller.retention.frequencyInSeconds";
- private static final String VALIDATION_MANAGER_FREQUENCY_IN_SECONDS =
"controller.validation.frequencyInSeconds";
- private static final String STATUS_CHECKER_FREQUENCY_IN_SECONDS =
"controller.statuschecker.frequencyInSeconds";
- private static final String REALTIME_SEGMENT_RELOCATOR_FREQUENCY =
"controller.realtime.segment.relocator.frequency";
- private static final String STATUS_CHECKER_WAIT_FOR_PUSH_TIME_IN_SECONDS =
"controller.statuschecker.waitForPushTimeInSeconds";
+
+ public static class ControllerPeriodicTasksConf {
+ private static final String RETENTION_MANAGER_FREQUENCY_IN_SECONDS =
"controller.retention.frequencyInSeconds";
+ private static final String
OFFLINE_SEGMENT_INTERVAL_CHECKER_FREQUENCY_IN_SECONDS =
+ "controller.offline.segment.interval.checker.frequencyInSeconds";
+ private static final String
REALTIME_SEGMENT_VALIDATION_FREQUENCY_IN_SECONDS =
Review comment:
The new offline segment frequency and broker resource validation frequency
should be picked up from the ValidationManager frequency configured (if they
are not individually configured).
I would like to say that for realtime segment validation as well, but since
we are increasing the frequency there, maybe it is ok to move to the new
derfault.
Specifically, we cannot remove the controller.validation.frequency. We can
mark it as deprecated and remove after some time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
