mcvsubbu commented on a change in pull request #3644: Split ValidationManager
duties into separate ControllerPeriodicTasks
URL: https://github.com/apache/incubator-pinot/pull/3644#discussion_r245798014
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerConf.java
##########
@@ -321,58 +339,118 @@ public String getControllerVipProtocol() {
}
public int getRetentionControllerFrequencyInSeconds() {
- if (containsKey(RETENTION_MANAGER_FREQUENCY_IN_SECONDS)) {
- return Integer.parseInt((String)
getProperty(RETENTION_MANAGER_FREQUENCY_IN_SECONDS));
+ if
(containsKey(ControllerPeriodicTasksConf.RETENTION_MANAGER_FREQUENCY_IN_SECONDS))
{
+ return Integer.parseInt((String)
getProperty(ControllerPeriodicTasksConf.RETENTION_MANAGER_FREQUENCY_IN_SECONDS));
}
- return DEFAULT_RETENTION_CONTROLLER_FREQUENCY_IN_SECONDS;
+ return
ControllerPeriodicTasksConf.DEFAULT_RETENTION_CONTROLLER_FREQUENCY_IN_SECONDS;
}
public void setRetentionControllerFrequencyInSeconds(int
retentionFrequencyInSeconds) {
- setProperty(RETENTION_MANAGER_FREQUENCY_IN_SECONDS,
Integer.toString(retentionFrequencyInSeconds));
+
setProperty(ControllerPeriodicTasksConf.RETENTION_MANAGER_FREQUENCY_IN_SECONDS,
+ Integer.toString(retentionFrequencyInSeconds));
}
+ /**
+ * Deprecated. The validation manager has been split into 3 separate tasks,
each having their own frequency config
+ * @return
+ */
+ @Deprecated
public int getValidationControllerFrequencyInSeconds() {
- if (containsKey(VALIDATION_MANAGER_FREQUENCY_IN_SECONDS)) {
- return Integer.parseInt((String)
getProperty(VALIDATION_MANAGER_FREQUENCY_IN_SECONDS));
+ if
(containsKey(ControllerPeriodicTasksConf.VALIDATION_MANAGER_FREQUENCY_IN_SECONDS))
{
+ return Integer.parseInt(
+ (String)
getProperty(ControllerPeriodicTasksConf.VALIDATION_MANAGER_FREQUENCY_IN_SECONDS));
}
- return DEFAULT_VALIDATION_CONTROLLER_FREQUENCY_IN_SECONDS;
+ return
ControllerPeriodicTasksConf.DEFAULT_VALIDATION_CONTROLLER_FREQUENCY_IN_SECONDS;
}
+ /**
+ * Deprecated. The validation manager has been split into 3 separate tasks,
each having their own frequency config
+ * @return
+ */
public void setValidationControllerFrequencyInSeconds(int
validationFrequencyInSeconds) {
- setProperty(VALIDATION_MANAGER_FREQUENCY_IN_SECONDS,
Integer.toString(validationFrequencyInSeconds));
+
setProperty(ControllerPeriodicTasksConf.VALIDATION_MANAGER_FREQUENCY_IN_SECONDS,
+ Integer.toString(validationFrequencyInSeconds));
+ }
+
+ public int getOfflineSegmentIntervalCheckerFrequencyInSeconds() {
+ if
(containsKey(ControllerPeriodicTasksConf.OFFLINE_SEGMENT_INTERVAL_CHECKER_FREQUENCY_IN_SECONDS))
{
+ return Integer.parseInt(
+ (String)
getProperty(ControllerPeriodicTasksConf.OFFLINE_SEGMENT_INTERVAL_CHECKER_FREQUENCY_IN_SECONDS));
+ }
+ return
ControllerPeriodicTasksConf.DEFAULT_OFFLINE_SEGMENT_INTERVAL_CHECKER_FREQUENCY_IN_SECONDS;
+ }
+
+ public void setOfflineSegmentIntervalCheckerFrequencyInSeconds(int
validationFrequencyInSeconds) {
+
setProperty(ControllerPeriodicTasksConf.OFFLINE_SEGMENT_INTERVAL_CHECKER_FREQUENCY_IN_SECONDS,
+ Integer.toString(validationFrequencyInSeconds));
+ }
+
+ public int getRealtimeSegmentValidationFrequencyInSeconds() {
+
+ if
(containsKey(ControllerPeriodicTasksConf.REALTIME_SEGMENT_VALIDATION_FREQUENCY_IN_SECONDS))
{
+ return Integer.parseInt(
+ (String)
getProperty(ControllerPeriodicTasksConf.REALTIME_SEGMENT_VALIDATION_FREQUENCY_IN_SECONDS));
+ }
+ return
ControllerPeriodicTasksConf.DEFAULT_REALTIME_SEGMENT_VALIDATION_FREQUENCY_IN_SECONDS;
+ }
+
+ public void setRealtimeSegmentValidationFrequencyInSeconds(int
validationFrequencyInSeconds) {
+
setProperty(ControllerPeriodicTasksConf.REALTIME_SEGMENT_VALIDATION_FREQUENCY_IN_SECONDS,
+ Integer.toString(validationFrequencyInSeconds));
+ }
+
+ /**
+ * Return broker resource validation frequency if present, else return the
validation manager frequency
+ * This is so that we can rollout with no config changes to the frequency of
this task
+ * @return
+ */
+ public int getBrokerResourceValidationFrequencyInSeconds() {
+ if
(containsKey(ControllerPeriodicTasksConf.BROKER_RESOURCE_VALIDATION_FREQUENCY_IN_SECONDS))
{
+ return Integer.parseInt(
+ (String)
getProperty(ControllerPeriodicTasksConf.BROKER_RESOURCE_VALIDATION_FREQUENCY_IN_SECONDS));
+ }
+ return getValidationControllerFrequencyInSeconds();
Review comment:
if controller.validation.frequencyInSeconds is configured, return it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
