mcvsubbu commented on a change in pull request #3644: Split ValidationManager 
duties into separate ControllerPeriodicTasks
URL: https://github.com/apache/incubator-pinot/pull/3644#discussion_r245794719
 
 

 ##########
 File path: 
pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerConf.java
 ##########
 @@ -348,6 +350,28 @@ public void setRetentionControllerFrequencyInSeconds(int 
retentionFrequencyInSec
         Integer.toString(retentionFrequencyInSeconds));
   }
 
+  /**
+   * Deprecated. The validation manager has been split into 3 separate tasks, 
each having their own frequency config
+   * @return
+   */
+  @Deprecated
+  public int getValidationControllerFrequencyInSeconds() {
 
 Review comment:
   we can make the getter private. Nobody outside of controller should be using 
this getter, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to