mcvsubbu commented on a change in pull request #3728: Support for specifying
Object Type in Schema
URL: https://github.com/apache/incubator-pinot/pull/3728#discussion_r249566783
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/data/FieldSpec.java
##########
@@ -86,6 +86,10 @@
@ConfigKey("virtualColumnProvider")
protected String _virtualColumnProvider;
+
+ //Complex type that can be constructed from raw bytes stored e.g. map, json,
text
+ @ConfigKey("objectType")
+ protected String _objectType;
Review comment:
I am not sure how/where the serialization (and deserialization) contract is
defined between Pinot and the entity that ingests data into Pinot (and the one
that reads it, and specifies queries against it).
I agree with using enums, so that we can start with some small number of
supported object types, I suppose
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
