mcvsubbu commented on a change in pull request #3728: Support for specifying
Object Type in Schema
URL: https://github.com/apache/incubator-pinot/pull/3728#discussion_r249568133
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/data/objects/JSONObject.java
##########
@@ -0,0 +1,65 @@
+package org.apache.pinot.common.data.objects;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.List;
+
+import org.apache.pinot.common.data.PinotObject;
+
+import com.beust.jcommander.internal.Lists;
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.node.JsonNodeFactory;
+
+public class JSONObject implements PinotObject {
Review comment:
May be useful to rename this class as PinotJSONObject. Every JSON library
(and there are several) probably has its own JSONObject :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
