mcvsubbu commented on a change in pull request #3728: Support for specifying 
Object Type in Schema
URL: https://github.com/apache/incubator-pinot/pull/3728#discussion_r249606413
 
 

 ##########
 File path: 
pinot-common/src/main/java/org/apache/pinot/common/data/FieldSpec.java
 ##########
 @@ -86,6 +86,10 @@
 
   @ConfigKey("virtualColumnProvider")
   protected String _virtualColumnProvider;
+  
+  //Complex type that can be constructed from raw bytes stored e.g. map, json, 
text
+  @ConfigKey("objectType")
+  protected String _objectType;
 
 Review comment:
   Let us say the object was a map (as per your example). Presumably, the 
entity that ingests data into Pinot has serialized a map into bytes using some 
serde. That serde method better be the same that Pinot uses to deserialize 
while fielding a query, or while returning result of a query (may have to 
deserialize, and serialize back to deserialize again). Did I understand it 
right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to