On 19/07/16 22:27, Ellison Anne Williams wrote: > It seems that we could give RTC a shot, with one reviewer posting a +1 (or > equivalent) comment on a pull request before it is accepted, and switch > back to CTR if RTC became too burdensome.
Who is a "reviewer"? I assume another commiter? > It seems healthy to foster explicit accountability and to give others the > opportunity to discuss changes before they are committed. This may become > too much for small commits, especially to the website, but we can always > adopt CTR (or a combination of the two for certain situations). > > Thoughts? Sounds good to me. Regarding small commits, for example, had you spotted the build break, which was simply a PR application timing issue between Travis and RAT adoption, I would hope you feel empowered to add the trivial one line fix proactively (and maybe mention it in the RAT PR/JIRA) rather than have to raise a new PR and get a +1. Regards, Tim
