Suneel It is probably a good idea to keep it there because it can really help with automating some of the checks as people put in PRs.
I'm happy to help do licensing/header hunting soon. Thanks Joe On Fri, Jul 22, 2016 at 6:53 PM, Suneel Marthi <[email protected]> wrote: > We r good now, I disabled the rat check to get past the build failure, i > guess we don't need that for travis, do we? > > On Fri, Jul 22, 2016 at 6:19 PM, Suneel Marthi <[email protected]> > wrote: > >> Getting a travis build error for RAT, any ideas ? I am not seeing this >> locally. >> >> [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check >> (default) on project pirk: Too many files with unapproved license: 1 See >> RAT report in: /home/travis/build/apache/incubator-pirk/target/rat.txt -> >> [Help 1] >> >> >> >> On Fri, Jul 22, 2016 at 6:07 PM, Suneel Marthi <[email protected]> >> wrote: >> >>> ... I am also gonna disable Jdk 7 jobs on travis as part of this change. >>> >>> OK with @here ? >>> >>> >>> On Fri, Jul 22, 2016 at 6:01 PM, Suneel Marthi <[email protected]> >>> wrote: >>> >>>> Let's go with Option 1, i can modify .travis.yml to account for Maven >>>> 3.3x >>>> >>>> On Fri, Jul 22, 2016 at 5:58 PM, Tim Ellison <[email protected]> >>>> wrote: >>>> >>>>> On 22 July 2016 at 22:13, Joe Witt <[email protected]> wrote: >>>>> >>>>> > Within NiFi we went with the "oldest version of Maven we could fairly >>>>> > easily support" approach. I really wish we had not. >>>>> > >>>>> > As a new project you have one shot to set some of the fundamentals >>>>> > down right such as the JVM you're tied to or the Maven build >>>>> > environment and such. I recommend, picking the most forward leaning >>>>> > one you think you'll need. It is really easy to install the latest >>>>> > version of Maven >>>>> >>>>> >>>>> Just checking I'm not missing something about installing the latest >>>>> version >>>>> of Maven on Travis. >>>>> >>>>> A quick search shows we need to either script the download of a later >>>>> version [1], or a seemingly better option is to define the entire build >>>>> env >>>>> using Docker[2]. >>>>> >>>>> [1] >>>>> >>>>> http://binkley.blogspot.co.uk/2015/10/struggling-with-travis-ci-and-maven-33.html >>>>> [2] >>>>> >>>>> http://blog.javabien.net/2015/08/21/travis-ci-on-a-java-project-with-docker-support/ >>>>> >>>>> Regards, >>>>> Tim >>>>> >>>>> >>>>> >>>>> > but it is really non-trivial if you're doing >>>>> > interesting things with Maven to maintain support over long periods of >>>>> > time for behaviors of older versions. >>>>> > >>>>> > I'd seriously recommend you take the latest Maven release and call >>>>> > that the Maven version. That is purely a recommendation. I'll help >>>>> > whatever path is the consensus. >>>>> > >>>>> >>>> >>>> >>> >>
