Github user DarinJ commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/93#discussion_r80029052
  
    --- Diff: 
src/main/resources/META-INF/services/org.apache.pirk.responder.wideskies.spi.ResponderPlugin
 ---
    @@ -0,0 +1,5 @@
    +org.apache.pirk.responder.wideskies.mapreduce.MapReduceResponder
    --- End diff --
    
    @ellisonanne the service-plugin model allows better extensibility than pure 
reflection and is a well known pattern so should be easier for others to 
develop new responders. 
    
    This means that we keep platform designators and a developer for a new 
responder adds his/her own designator via `getPlatformName` which will be 
available when the jar is on the class path.  (I could actually put those into 
the command line but I won't as the config is in flux - todo I guess). 
    
    It also allows a shorter command line 
    ```
    -p spark
    ```
    vs 
    ```
    -l org.apache.pirk.responder.wideskies.spark.SparkResponderLauncher
    ```
    with the same benefits.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to