Github user ellisonanne commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/93#discussion_r80058520
  
    --- Diff: 
src/main/resources/META-INF/services/org.apache.pirk.responder.wideskies.spi.ResponderPlugin
 ---
    @@ -0,0 +1,5 @@
    +org.apache.pirk.responder.wideskies.mapreduce.MapReduceResponder
    --- End diff --
    
    No - every option requires user specification. I had originally thought 
that we would have the user specify the interface implementation (via class 
name) via the command line/prop file and then instantiate through reflection. 
    
    I like the service-plugin model and am in favor of proceeding with it. It 
just wasn't what I thought we were doing when we started this PR (recall that 
we started with a ResponderLauncher interface + user specification of 
implementation) and wanted to make sure that we were clear on the tradespace.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to