Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/93#discussion_r80055483
--- Diff:
src/main/resources/META-INF/services/org.apache.pirk.responder.wideskies.spi.ResponderPlugin
---
@@ -0,0 +1,5 @@
+org.apache.pirk.responder.wideskies.mapreduce.MapReduceResponder
--- End diff --
> not only does the user have to specify the class/platform
Yes. Do you envisage some way in which the user could **not** have to
specify the platform they want Pirk to use?
> the code has to be aware, via a static list, of the possible plugin
> implementations (as listed in
org.apache.pirk.responder.wideskies.spi.ResponderPlugin)
The static list of plugins is in the ```META-INF/services file``` that
lists all the known implementers of that interface _in this JAR_. Today,
because we have one large JAR, all the responders are listed, but (i) when we
split into submodules each impl will move to its corresponding JAR artefact,
and (ii) anyone can now drop a JAR on the classpath with an impl declared in
it's services list, and Pirk will find it by getPlatformName.
How do you propose pirk-core finds the responder implementers at runtime?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
