Github user tellison commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/105#discussion_r81305924
--- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierProps.java
---
@@ -60,154 +59,179 @@
// Decryption properties
static final String QUERIERFILE = "querier.querierFile";
- static final List<String> PROPSLIST = Arrays.asList(ACTION, INPUTFILE,
OUTPUTFILE, QUERYTYPE, NUMTHREADS, EMBEDQUERYSCHEMA, HASHBITSIZE, HASHKEY,
- DATAPARTITIONSIZE, PAILLIERBITSIZE, BITSET, CERTAINTY, QUERYSCHEMAS,
DATASCHEMAS, EMBEDSELECTOR, USEMEMLOOKUPTABLE, USEHDFSLOOKUPTABLE, SR_ALGORITHM,
- SR_PROVIDER);
+ static final List<String> PROPSLIST = Arrays
+ .asList(ACTION, INPUTFILE, OUTPUTFILE, QUERYTYPE, NUMTHREADS,
EMBEDQUERYSCHEMA, HASHBITSIZE, HASHKEY, DATAPARTITIONSIZE, PAILLIERBITSIZE,
BITSET,
+ CERTAINTY, QUERYSCHEMAS, DATASCHEMAS, EMBEDSELECTOR,
USEMEMLOOKUPTABLE, USEHDFSLOOKUPTABLE, SR_ALGORITHM, SR_PROVIDER);
- /**
- * Validates the querier properties
- *
- */
public static boolean validateQuerierProperties()
{
+ setGeneralDefaults(SystemConfiguration.getProperties());
+
if(validateGeneralQuerierProperties(SystemConfiguration.getProperties())) {
+ String action =
SystemConfiguration.getProperty(ACTION).toLowerCase();
--- End diff --
Trivial: does not follow house formatting rules ;-)
I believe this has subsequently been fixed by @ellisonanne
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
