I will take off the author info and push - I meant to do this yesterday when I reformatted...
On Fri, Sep 30, 2016 at 5:31 AM, tellison <[email protected]> wrote: > Github user tellison commented on a diff in the pull request: > > https://github.com/apache/incubator-pirk/pull/105#discussion_r81305132 > > --- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierCLI.java > --- > @@ -131,12 +125,28 @@ private boolean parseOptions() > // Validate properties > valid = QuerierProps.validateQuerierProperties(); > > + // Load the new local query and data schemas > + if (valid) > + { > + logger.info("loading schemas: dataSchemas = " + > SystemConfiguration.getProperty("data.schemas") + " querySchemas = " + > SystemConfiguration > + .getProperty("query.schemas")); > + try > + { > + DataSchemaLoader.initialize(); > + QuerySchemaLoader.initialize(); > + > + } catch (Exception e) > --- End diff -- > > It would be much better to handle the exception, or re-throw it, > rather than consume and continue. > Why catch all Exception types? > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > --- >
