Github user jryancarr commented on a diff in the pull request:
https://github.com/apache/incubator-pirk/pull/105#discussion_r81339999
--- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierCLI.java
---
@@ -131,12 +125,28 @@ private boolean parseOptions()
// Validate properties
valid = QuerierProps.validateQuerierProperties();
+ // Load the new local query and data schemas
+ if (valid)
+ {
+ logger.info("loading schemas: dataSchemas = " +
SystemConfiguration.getProperty("data.schemas") + " querySchemas = " +
SystemConfiguration
+ .getProperty("query.schemas"));
+ try
+ {
+ DataSchemaLoader.initialize();
+ QuerySchemaLoader.initialize();
+
+ } catch (Exception e)
--- End diff --
This code was moved out of the old QuerierProps.validateQuerierProperties()
method. I decided it would be safe to move out since this was the only place
that method was ever called, and this code doing initialization, not
validation. But I'm not familiar enough yet with what the schema loaders are
doing to understand how to handle those exceptions differently. Any suggestions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
