Hi,

+1 (binding) IMO There’s some license/notice issues that need to be fixed for 
the next release.

I checked:
- incubating in name
- signatures and hashes good
- DISCLAIMER exists
- LICENSE and NOTICE need some work (see below)
- No unexpected binary fines
- All source files have ASF headers
- Can compile from source

LICENSE is missing license info for Netty and this ALv2 file [1], this is 
optional but recommended.] NOTICE is missing information from Netty's NOTICE 
file.

Do we know where [1] comes from and if so does it have a NOTICE file?

Also no need to include md5 hash as it’s no longer considered secure and ASF 
policy has changed.

Thanks,
Justin

1. 
./apache-plc4x-incubating-0.1.0/examples/google/src/main/java/org/apache/plc4x/java/examples/google/iotcore/MqttExampleOptions.java


Reply via email to