Heyho,
I checked
* no incubating in name or DISCLAIMER file
* signatures and hashes correct (also used Chris' toolset)
* all source files have ASF headers (rat plugin)
* can build from sources on all major OS:
- OS X 10.14.4 (09:53min)
- Win 10 (Version 1803), (23:15min)
- CentOS7 (14:02min)
Command on
* Mac and Linux{1}: `./mvnw -P
with-java,with-cpp,with-dotnet,with-python,with-proxies,with-sandbox install`
* Win{2}: ' mvnw.cmd -P with-java -P with-python -P with-proxies -P with-dotnet
-P with-cpp -P with-python install'
So +1 (binding)
for 0.4.0-RC1
Best
Tim
{1}: for a strange reason on some VMs occur a failing tests with
UnknownHostException, will investigate on that further
{2}: Suggestion - if build fails due to crashin forked VM: pipe cmd-line output
to a file outside build folder ( ... > C:\tmp\build.log ) (due to rat-check);
for some strange reason on some VMs the cmd logging gets to big, see also [3];
furthermore around RAM 2GB peak is needed
[3]: https://stackoverflow.com/a/52033799
Am 22.05.19, 00:08 schrieb "Christofer Dutz" <[email protected]>:
Apache PLC4X 0.4.0 has been staged under [2] and it’s time to vote
on accepting it for release. All Maven artifacts are available under [1].
Voting will be open for 72hr.
A minimum of 3 binding +1 votes and more binding +1 than binding -1
are required to pass.
Release tag: release/0.4.0
Hash for the release tag: 10739fd4a6d201364d5021c78e7e1c529f04336d
Per [3] "Before voting +1 PMC members are required to download
the signed source code package, compile it as provided, and test
the resulting executable on their own platform, along with also
verifying that the package meets the requirements of the ASF policy
on releases."
You can achieve the above by following [4].
[ ] +1 accept (indicate what you validated - e.g. performed the non-RM
items in [4])
[ ] -1 reject (explanation required)
[1]
https://repository.apache.org/content/repositories/orgapacheplc4x-1009
[2] https://dist.apache.org/repos/dist/dev/plc4x/0.4.0/rc1
[3] https://www.apache.org/dev/release.html#approving-a-release
[4]
https://cwiki.apache.org/confluence/display/PLC4X/Validating+a+staged+Release
