Hi all, myself having found some issues as well as Justins concerns, I have decided to cancel the vote ... I know the issues I found were minor, but as I could see from Matthias' questions on Slack it does make it difficult to build. I don't want to put the burden on our users therefore think we should fix those problems (Well in develop they already are ...)
It would be great if Justin could checkout the updates to the legal documents on develop ... I want RC3 to be perfect in these regards. Chris Am 27.10.19, 09:35 schrieb "Justin Mclean" <[email protected]>: Hi, -1 (binding) due to license issues. I checked: - signatures and hashes fine - LICENSE is missing license for these two files [1][2]. Does it come form here [3]? - LICENSE is missing license for this file [4] (and rat clearly shows this) - no unexpected binary files - all source files have ASF headers - can compile from sorry I’m am a little confused by the Maven wrapper header which states incorrectly "Copyright 2007-present the original author or authors.” but I think that’s there issue not ours. Thanks, Justin 1. ./sandbox/streampipes-connectors/src/main/java/org/apache/plc4x/java/streampipes/bacnetip/config/ConfigKeys.java 2. ./sandbox/streampipes-connectors/src/main/java/org/apache/plc4x/java/streampipes/bacnetip/config/ConnectWorkerConfig.java 3. https://github.com/streampipes/streampipes 4. apache-plc4x-0.5.0/build-utils/protocol-base-mspec/src/main/antlr4/org/apache/plc4x/plugins/codegenerator/language/mspec/expression/Expression.g4
