Hi, fully agree with Matthias here (<3). Optional is way better as I usually also do not have my docker host running as it drains too much energy __
Julian Am 11.12.19, 10:38 schrieb "Strljic, Matthias Milan" <[email protected]>: Hi Chris, for build compatibility I would go with option 2. Even if I am from the anti-profil-option party. With option 1 the PLC4X complete build would be failing because of a missing docker dependency. Greetings to all Windows users which do not want to use the Hyper-V especially with Windows-Core and Windows on ARM. Mathi Matthias Strljic, M.Sc. Universität Stuttgart Institut für Steuerungstechnik der Werkzeugmaschinen und Fertigungseinrichtungen (ISW) Seidenstraße 36 70174 Stuttgart GERMANY Tel: +49 711 685-84530 Fax: +49 711 685-74530 E-Mail: [email protected] Web: http://www.isw.uni-stuttgart.de -----Ursprüngliche Nachricht----- Von: Christofer Dutz <[email protected]> Gesendet: Wednesday, December 11, 2019 10:05 AM An: [email protected] Betreff: [DISCUSS] How to handle Docker? Hi all, yesterday I had a look at what’s missing in order for us to ship fully functional StreamPipe modules. Adding the missing spring-boot repackaging was simple. I also added Dockerfiles for both modules that successfully build docker images and should theoretically also deploy them to dockerhub. HOWEVER … the build like this only works with Docker installed on your system. So now to my question 1: * Do we want to make Docker mandatory? … then I would add a check to the setup script * Do we enable the Docker stuff by adding a “with-docker” profile? … this too would add a Docker detection to the script, but this is only executed if the profile is enabled. I would opt for option 2 with the profile and to add this to the configuration of the release-plugin that this also enables the “with-docker” profile. I am however hesitant as I have noticed that some people in the community dislike having all these profiles and we just got rid of some. Second thing is: Do we want to distribute Docker images of things that need it? And if yes, how do we do it correctly (Justin … this part of the question is generally directed to you ;) ) I would like to distribute the StreamPipes images and if things are added, that require it, those too (Perhaps one day the Mock PLC and stuff like that). However I don’t want to distribute our examples this way. Please share your thoughts on these questions. Chris
