Nice, then thats the way to go!

Am 06.04.20, 10:21 schrieb "Christofer Dutz" <[email protected]>:

    I've already got an annotation you can use:
    @RequirePcap together with a Junit Condition, that skips the test if the 
condition is not met ... just noticed a bug in my condition however __ ... just 
fixing it.
    
    Chris
    
    
    Am 06.04.20, 10:11 schrieb "Julian Feinauer" <[email protected]>:
    
        Hey,
        
        I would not choose 1, as you say.
        Perhaps we can make this tests conditional (dont know how easy this is 
with junit5) an das you say, only allow releases with libpcap.
        
        Julian
        
        Am 06.04.20, 10:07 schrieb "Christofer Dutz" 
<[email protected]>:
        
            Hi,
            
            I’m currently working on the prerequisiteCheck for my new plc4c 
module and am testing on empty OSes (OSes without any installed additional 
software)
            I noticed there are tests like the Raw-Socket test that naturally 
fail if you don’t have libpcap (or the windows counterpart installed) …
            
            We now have two options:
            
              1.  Make libpcap mandatory
              2.  Disable any test that is libpcap related
            
            1) is the more secure version, but I think some people might have 
objections to installing libpcap on their systems.
            
            How about automatically disabling these tests and to have a check 
in the prerequisiteChecks to not allow doing an “apache-release” without 
libpcap?
            
            Got any other ideas?
            
            Chris
            
        
        
    
    

Reply via email to