chrisdutz commented on a change in pull request #174:
URL: https://github.com/apache/plc4x/pull/174#discussion_r462835926
##########
File path: protocols/modbus/src/main/resources/protocols/modbus/modbus.mspec
##########
@@ -247,9 +247,9 @@
]
[type 'ModbusPDUReadFileRecordResponseItem'
- [implicit uint 8 'dataLength' '(COUNT(data) * 2) + 1']
+ [simple uint 8 'dataLength']
Review comment:
No ... it would read the 0x03 as length (When parsing implicits are
parsed just like simple fields, however they are not stored in a property as
this information can be calculated by the given expression when serializing)
... so when parsing the 0x03 would be parsed and would be available to other
parsing expressions as dataLength (which would be used to know how many
elements of "data" have to be read). When serializing instead of reading a
property of the object, it would check how many elements the "data" array has
and add 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
