hutcheb commented on a change in pull request #225:
URL: https://github.com/apache/plc4x/pull/225#discussion_r561792739



##########
File path: 
plc4j/integrations/opcua-server/src/main/java/org/apache/plc4x/java/opcuaserver/backend/Plc4xCommunication.java
##########
@@ -115,9 +71,27 @@
     Map<NodeId, DataItem> monitoredList = new HashMap<>();
 
     public Plc4xCommunication () {
+
+    }
+
+    @Override
+    protected void onStartup() {
         driverManager = new PooledPlcDriverManager();
     }
 
+    @Override

Review comment:
       It overrides an abstract method, I don't really have much to do on 
shutdown. I've added a comment to indicate that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to