[GitHub] [plc4x] ottobackwards commented on a change in pull request #225: Add encryption handler for OPC UA - Minor fix for Kafka Connector

[GitBox]

ottobackwards commented on a change in pull request #225:
URL: https://github.com/apache/plc4x/pull/225#discussion_r561843725



##########
File path: 
plc4j/integrations/opcua-server/src/main/java/org/apache/plc4x/java/opcuaserver/backend/Plc4xCommunication.java
##########
@@ -65,6 +65,7 @@
     private final Logger logger = LoggerFactory.getLogger(getClass());
     private final Integer DEFAULT_TIMEOUT = 1000000;
     private final Integer DEFAULT_RETRY_BACKOFF = 5000;
+    private final DataValue BAD_RESPONSE = new DataValue(new Variant(null), 
StatusCode.BAD);

Review comment:
       should this be static?

##########
File path: 
plc4j/integrations/opcua-server/src/main/java/org/apache/plc4x/java/opcuaserver/backend/Plc4xCommunication.java
##########
@@ -115,9 +71,27 @@
     Map<NodeId, DataItem> monitoredList = new HashMap<>();
 
     public Plc4xCommunication () {
+
+    }
+
+    @Override
+    protected void onStartup() {
         driverManager = new PooledPlcDriverManager();
     }
 
+    @Override

Review comment:
       ah, IC,  you can't tell if it is abstract base or interface, always 
catches me.  thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org