chrisdutz commented on a change in pull request #305:
URL: https://github.com/apache/plc4x/pull/305#discussion_r789644825
##########
File path:
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/configuration/ConfigurationFactory.java
##########
@@ -178,63 +171,78 @@ private static Object toFieldValue(Field field, String
valueString) {
try {
ConfigurationParameterConverter<?> converter =
converterClass.getDeclaredConstructor().newInstance();
if (converter.getType().isAssignableFrom(field.getType())) {
- return converter.convert(valueString);
+ valueString = converter.convert(valueString).toString();
Review comment:
IntelliJ is reporting that this value is never used. This is due to the
fact that in line 179 you are always throwing an exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
