takraj commented on code in PR #1163:
URL: https://github.com/apache/plc4x/pull/1163#discussion_r1365407396
##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/Plc4xNettyWrapper.java:
##########
@@ -152,6 +152,11 @@ protected void decode(ChannelHandlerContext
channelHandlerContext, T t, List<Obj
continue;
}
// Timeout?
+ if (registration.isDone()) {
Review Comment:
Yes, I think you are right, these two could be merged together. Moreover, if
`isCancelled()` is `true`, `isDone()` is also `true`, so it would be already
enough to check the latter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
